TD-23945, TD-24495: [TD704] wrong context row when calling SalTblDeleteRow() and SalGridApplyState()

[Uwe van der Horst]

We have found a mayor problem with 7.0.4. In some cases we are filling Grids in the follwing way (columns as bind variables):

Call SqlPrepareAndExecute( hSql, 'select x, y into :col1, :col2 from z' )
Call SalTblSetContext( hWndForm, SalTblInsertRow( hWndForm, TBL_MaxRow ) )
While SqlFetchNext( hSql, nDummy )
...Call SalTblSetContext( hWndForm, SalTblInsertRow( hWndForm, TBL_MaxRow ) )
Call SalTblDeleteRow( hWndForm, SalTblQueryContext( hWndForm ), TBL_MaxRow )

Logically after processing the While SqlFetchNext... we have to delete the last row because it is empty. Here is the regression:

With TD 7.0.3 and all previous versions after calling SalTblDeleteRow() the context row is "TBL_Error". This is the expected behaviour.
With TD 7.0.4 after calling SalTblDeleteRow() the context row is "row 0". This can cause some heavy unwanted effects.

I have attached a test case that shows the probem. Extract the .zip and run the .exe (not the .apt). With the cdlli70.dll (version 7.0.4) the context row is 0 (wrong). With the cdlli70.dll (version 7.0.3) the context row is TBL_Error (ok).

I will make a support case.

SalTblDeleteRowGivesWrongContextRow.zip

[Dave Rabelink]

I can confirm this, Uwe.

[Uwe van der Horst]

The bug number is TD-23945.

[Uwe van der Horst]

This bug is fixed in TD 7.05 and 7.1.

[Uwe van der Horst]

The issue is partially back in 7.1.2 (not checked with 7.1.1). When filling the grid from outside the behaviour is different from filling the grid from inside of the grid.

no problems here:
On SAM_CreateComplete
... fFillGrid()
Here when calling SalGridApplyState() the grid might be sorted, but row 0 has the context.

different behaviour:
Call SalCreateWindow( grid1, hWndMDI)
Call grid1.fFillGrid()
Here when calling SalGridApplyState() the grid might be sorted and then we have a row somewhere in the middle of the grid that has the context (= "row 0" BEFORE calling SalGridApplyState).
Maybe customer does not notice and marks multiple rows by holding ctrl. Then we have one more line selected. Think about attached documents with secret information that customer sends to a person via E-Mail...

The new number is TD-24495, fix is requested for the 7.1.3 release.

[Uwe van der Horst]

This is fixed in TD 7.1.3 and 7.2 Beta.