TD-22922: SalXMLDeserializeDateTime conversion incorrect

[Dave Rabelink]

Since TD 5.1 we have this function __SalXMLDeserializeDateTime (from SalXMLws.apl) which is used to convert a XML DateTime string to TD DateTime value in webservices.

In all TD versions, the TD implementation is incorrect. Including the latest TD 6.3.

First a list of possible XML DateTime example values:

A) "2016-11-28T23:59:49"
B) "2016-11-28T23:59:49Z"
C) "2016-11-28T23:59:49-06:00"
D) "2016-11-28T23:59:49+06:00"

In all cases, the datetime in TD should be:

2016-11-28 23:59:49

Right now, only B) and D) are correctly converted.
Examples A) and C) will result in:

2016-11-27 22.58.59

Looking at the implementation, the cause is clear.

The line

Set sXMLParsed = '1900-01-01-' || sXMLParsed

should be done AFTER the checks for Z, + and - and not before.
Right now, the '1900-01-01-' part of the string will be used to check if it contains a - sign. This is always the case and it results in an invalid datetime.

Secondly:
Even the corrected functionality is incorrect as it just strips Z, + and - signs from the DateTime. There is a reason why these characters are there.
When TD converts the XML value it should REALLY convert to the timezone and daysavings of the system it is running on.

See sample (saved in TD51 format). Select the XML value in the combo and execute. See the datetime result in the field.

PS
This issue was earlier reported here:
viewtopic.php?t=69175

[Dave Rabelink]

Gupta has assigned a defect number for this issue:

OTCS Ticket 2666239
TD-22922: __SalXMLDeserializeDateTime conversion incorrect


Use attached library to fix the issue.

SalXmlWS.zip